Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17189 )
Change subject: KUDU-2871 support TLSv1.3 in Kudu RPC (C++ part) ...................................................................... Patch Set 6: (1 comment) The updated tls_context.cc looks good to me. http://gerrit.cloudera.org:8080/#/c/17189/5/src/kudu/security/tls_context.cc File src/kudu/security/tls_context.cc: http://gerrit.cloudera.org:8080/#/c/17189/5/src/kudu/security/tls_context.cc@259 PS5, Line 259: // those might be none. From the other side, the implementation of : // SSL_CTX_set_cipher_list() verifies that the overall result list of ciphers : // is valid and usable, reporting an error otherwise. : // : // However, if the sequence is reversed, no error would be reported in case : // o > Thank you for the feedback! Thanks for fixing this! -- To view, visit http://gerrit.cloudera.org:8080/17189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia92a4d102c3c8cff76101e71ff71d24a9d78b672 Gerrit-Change-Number: 17189 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 30 Mar 2021 00:11:19 +0000 Gerrit-HasComments: Yes
