Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17189 )
Change subject: KUDU-2871 support TLSv1.3 in Kudu RPC (C++ part) ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/17189/8/src/kudu/security/security_flags.cc File src/kudu/security/security_flags.cc: http://gerrit.cloudera.org:8080/#/c/17189/8/src/kudu/security/security_flags.cc@29 PS8, Line 29: // TODO(aserbin): refresh the list to drop RHEL6/CentOS6 ciphers and > That's I'm sure about. We might want to keep backward compatibility for th Makes sense. http://gerrit.cloudera.org:8080/#/c/17189/8/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17189/8/src/kudu/server/server_base.cc@167 PS8, Line 167: DEFINE_string(rpc_tls_1_3_ciphers, > What's exactly the challenge here? Just consider this as the parameter to The OpenSSL API doesn't use the version number to signify the difference instead it uses ciphersuites vs cipherlist. Maybe to match the OpenSSL terminoligy this flag should be rpc_tls_ciphersuites with similar documentation to OpenSSL on the difference? -- To view, visit http://gerrit.cloudera.org:8080/17189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia92a4d102c3c8cff76101e71ff71d24a9d78b672 Gerrit-Change-Number: 17189 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 06 Apr 2021 14:23:23 +0000 Gerrit-HasComments: Yes
