Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17189 )
Change subject: KUDU-2871 support TLSv1.3 in Kudu RPC (C++ part) ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/17189/8/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17189/8/src/kudu/server/server_base.cc@167 PS8, Line 167: DEFINE_string(rpc_tls_1_3_ciphers, > Yep, let's explore this route. With '--rpc_tls_ciphersuites' my concern is I agree the naming is close. That said, anyone who knows openssl enough to know to set the cyphers is also probably familiar with the naming convention set by openssl. The naming scheme is uniform across openssl and kudu. -- To view, visit http://gerrit.cloudera.org:8080/17189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia92a4d102c3c8cff76101e71ff71d24a9d78b672 Gerrit-Change-Number: 17189 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 06 Apr 2021 17:44:35 +0000 Gerrit-HasComments: Yes
