Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17025 )
Change subject: KUDU-2671: Adds new field to PartitionSchema. ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/17025/9/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/17025/9/src/kudu/common/partition-test.cc@1303 PS9, Line 1303: PartitionSchema partition_schema; : ASSERT_OK(PartitionSchema::FromPB(pb, schema, &partition_schema)); > hm I could but then there would be less flexibility since the PartitionSche I meant in addition to the checks on these fields, doing another verification of deserialization/serialization, especially because we can drop it into other test cases easily. http://gerrit.cloudera.org:8080/#/c/17025/9/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17025/9/src/kudu/common/partition.cc@204 PS9, Line 204: if (ops.size() != 2) { > nope, there should only be two ops, I can modify the code to return an erro Seems like we make that assumption here: https://github.com/apache/kudu/blob/master/src/kudu/master/catalog_manager.cc#L2462 I suppose it's a different area of code, but since these rows are coming from clients, we have control over it anyway. http://gerrit.cloudera.org:8080/#/c/17025/10/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17025/10/src/kudu/common/partition.cc@205 PS10, Line 205: ("Only two ops are expected for this pair of range bounds."); nit: maybe also mention how many there are? -- To view, visit http://gerrit.cloudera.org:8080/17025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5d8615ab9967fdb40292b9c77eb68a19baeca1d Gerrit-Change-Number: 17025 Gerrit-PatchSet: 10 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 31 Mar 2021 18:25:57 +0000 Gerrit-HasComments: Yes
