Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17025 )
Change subject: KUDU-2671: Adds new field to PartitionSchema. ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/17025/9/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/17025/9/src/kudu/common/partition-test.cc@1303 PS9, Line 1303: : // [(a2, _, c4), (a2, _, c5)) > I meant in addition to the checks on these fields, doing another verificati Ack http://gerrit.cloudera.org:8080/#/c/17025/9/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17025/9/src/kudu/common/partition.cc@204 PS9, Line 204: if (ops.size() != 2) { > Seems like we make that assumption here: https://github.com/apache/kudu/blo Ack http://gerrit.cloudera.org:8080/#/c/17025/10/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17025/10/src/kudu/common/partition.cc@205 PS10, Line 205: (Substitute("$0 ops were provided; Only two ops are expected > nit: maybe also mention how many there are? Done -- To view, visit http://gerrit.cloudera.org:8080/17025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5d8615ab9967fdb40292b9c77eb68a19baeca1d Gerrit-Change-Number: 17025 Gerrit-PatchSet: 11 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 31 Mar 2021 23:25:51 +0000 Gerrit-HasComments: Yes
