Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17025 )
Change subject: KUDU-2671: Adds new field to PartitionSchema. ...................................................................... Patch Set 11: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/17025/11/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/17025/11/src/kudu/common/partition-test.cc@1355 PS11, Line 1355: CheckSerializationFunctions(pb, partition_schema, schema); This test verifies one specific partition schema. Could we call this from a few of our other tests that have per-range hash schemas, at least to get some coverage of some other interestingly shaped schemas? http://gerrit.cloudera.org:8080/#/c/17025/11/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17025/11/src/kudu/common/partition.cc@269 PS11, Line 269: Arena arena(256); Can we only allocate this and run through the loop if `ranges_with_hash_schemas_` is non-empty? -- To view, visit http://gerrit.cloudera.org:8080/17025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5d8615ab9967fdb40292b9c77eb68a19baeca1d Gerrit-Change-Number: 17025 Gerrit-PatchSet: 11 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 09 Apr 2021 20:56:32 +0000 Gerrit-HasComments: Yes
