Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17318 )
Change subject: [thirdparty] enable building curl with alternative OpenSSL ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17318/1/thirdparty/patches/curl-custom-openssl-library.patch File thirdparty/patches/curl-custom-openssl-library.patch: http://gerrit.cloudera.org:8080/#/c/17318/1/thirdparty/patches/curl-custom-openssl-library.patch@10 PS1, Line 10: + dnl Finally, set flags to use SSL. : + dnl If another version of OpenSSL library is present under the 'standard' : + dnl system paths, it's necessary to pick up the header and binary files : + dnl of the custom OpenSSL library, so put OpenSSL's custom paths first : + dnl for both the preprocessor and the linker. > I'm curious, is it best practice to prefer system defaults even when settin I don't think that's some sort of best practice. I guess that's just some copy-paste piece from somewhere else. I'll try to submit a patch request into the curl's upstream repo. But I might be missing something -- I haven't done much research yet in that direction, frankly. Anyways, if this turns out to not kosher enough, we can always remove this patch and do something else as recommended by the curl upstream maintainers. -- To view, visit http://gerrit.cloudera.org:8080/17318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia47c60b0dcef0212c777d628ab8c2f0be9c0a368 Gerrit-Change-Number: 17318 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 14 Apr 2021 22:24:57 +0000 Gerrit-HasComments: Yes
