Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17318 )
Change subject: [thirdparty] enable building curl with alternative OpenSSL ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17318/1/thirdparty/patches/curl-custom-openssl-library.patch File thirdparty/patches/curl-custom-openssl-library.patch: http://gerrit.cloudera.org:8080/#/c/17318/1/thirdparty/patches/curl-custom-openssl-library.patch@10 PS1, Line 10: + dnl Finally, set flags to use SSL. : + dnl If another version of OpenSSL library is present under the 'standard' : + dnl system paths, it's necessary to pick up the header and binary files : + dnl of the custom OpenSSL library, so put OpenSSL's custom paths first : + dnl for both the preprocessor and the linker. > I see, thanks for that context. I'm ok merging this as is, just thought it I'm not sure about the desirable behavior to pick up what's available in 'default' location. The reason I think so the --with-ssl=PATH option exposed curl's configure script: --with-ssl=PATH Where to look for OpenSSL, PATH points to the SSL installation (default: /usr/local/ssl); when possible, set the PKG_CONFIG_PATH environment variable instead of using this option I bet we have just hit a bug and this patch addresses it. As I mentioned, this bug doesn't manifest itself unless there is drastic difference in API of OpenSSL libraries, at default vs non-default locations. -- To view, visit http://gerrit.cloudera.org:8080/17318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia47c60b0dcef0212c777d628ab8c2f0be9c0a368 Gerrit-Change-Number: 17318 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 15 Apr 2021 01:30:41 +0000 Gerrit-HasComments: Yes
