Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17318 )
Change subject: [thirdparty] enable building curl with alternative OpenSSL ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17318/1/thirdparty/patches/curl-custom-openssl-library.patch File thirdparty/patches/curl-custom-openssl-library.patch: http://gerrit.cloudera.org:8080/#/c/17318/1/thirdparty/patches/curl-custom-openssl-library.patch@10 PS1, Line 10: + dnl Finally, set flags to use SSL. : + dnl If another version of OpenSSL library is present under the 'standard' : + dnl system paths, it's necessary to pick up the header and binary files : + dnl of the custom OpenSSL library, so put OpenSSL's custom paths first : + dnl for both the preprocessor and the linker. > I don't think that's some sort of best practice. I guess that's just some I see, thanks for that context. I'm ok merging this as is, just thought it was curious since this seems like it might be desirable behavior for curl in general. -- To view, visit http://gerrit.cloudera.org:8080/17318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia47c60b0dcef0212c777d628ab8c2f0be9c0a368 Gerrit-Change-Number: 17318 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 15 Apr 2021 00:53:40 +0000 Gerrit-HasComments: Yes
