Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17343 )
Change subject: [client] retry master RPCs on network errors ...................................................................... Patch Set 1: (1 comment) The intent of the change makes sense. Though looks like there are bunch of related test failures. http://gerrit.cloudera.org:8080/#/c/17343/1/src/kudu/client/txn_manager_proxy_rpc.cc File src/kudu/client/txn_manager_proxy_rpc.cc: http://gerrit.cloudera.org:8080/#/c/17343/1/src/kudu/client/txn_manager_proxy_rpc.cc@106 PS1, Line 106: if (deadline < now) { : SendRpcCb(Status::TimedOut("timed out after deadline expired")); : return; : } This check is already made above on L99. -- To view, visit http://gerrit.cloudera.org:8080/17343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae2febb9e890acf6f7efd5cce3cb7e4f7b5f683d Gerrit-Change-Number: 17343 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 27 Apr 2021 17:16:56 +0000 Gerrit-HasComments: Yes
