Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17343 )
Change subject: [client] retry master RPCs on network errors ...................................................................... Patch Set 5: > Patch Set 3: Verified+1 > > (3 comments) > > Overall looks good, but there is one strange failure in > ClientTest.TxnKeepAliveAndUnavailableTxnManagerLongTime. I'm not sure I > understood what's going on, but it hints maybe requests are retried even in > case of Status::IllegalState()? I think the issue was the timeout was too low for the TxnManager to fully initialize, so we ended up retrying until the eventual timeout. I bumped the client timeout and looped it: 300/300 passed in debug mode. -- To view, visit http://gerrit.cloudera.org:8080/17343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae2febb9e890acf6f7efd5cce3cb7e4f7b5f683d Gerrit-Change-Number: 17343 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 28 Apr 2021 00:23:59 +0000 Gerrit-HasComments: No
