Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17343 )
Change subject: [client] retry master RPCs on network errors ...................................................................... Patch Set 3: Verified+1 (3 comments) Overall looks good, but there is one strange failure in ClientTest.TxnKeepAliveAndUnavailableTxnManagerLongTime. I'm not sure I understood what's going on, but it hints maybe requests are retried even in case of Status::IllegalState()? http://gerrit.cloudera.org:8080/#/c/17343/1/src/kudu/client/txn_manager_proxy_rpc.cc File src/kudu/client/txn_manager_proxy_rpc.cc: http://gerrit.cloudera.org:8080/#/c/17343/1/src/kudu/client/txn_manager_proxy_rpc.cc@110 PS1, Line 110: template <class ReqClass, class RespClass> : string AsyncRandomTxnManagerRpc<ReqClass, RespClass>::ToString() const { : return rpc_name_; : } : > As it turns out, the issue I was seeing was because of the client disappear Thank you for the clarification. http://gerrit.cloudera.org:8080/#/c/17343/1/src/kudu/client/txn_manager_proxy_rpc.cc@115 PS1, Line 115: mplate <class Req > Mentioned elsewhere, this seems specific to keepalive and I addressed it in Thanks! http://gerrit.cloudera.org:8080/#/c/17343/1/src/kudu/integration-tests/txn_status_table-itest.cc File src/kudu/integration-tests/txn_status_table-itest.cc: http://gerrit.cloudera.org:8080/#/c/17343/1/src/kudu/integration-tests/txn_status_table-itest.cc@487 PS1, Line 487: > Done Thank you! My thought that in the future we might have different ID returned for the very first transaction started, and with current comment it's much clearer what we are trying to achieve with this ASSERT -- To view, visit http://gerrit.cloudera.org:8080/17343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae2febb9e890acf6f7efd5cce3cb7e4f7b5f683d Gerrit-Change-Number: 17343 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 27 Apr 2021 23:33:40 +0000 Gerrit-HasComments: Yes
