Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17350 )
Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17350/1/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/17350/1/src/kudu/integration-tests/master_hms-itest.cc@78 PS1, Line 78: opts.principal = "oryx"; > This won't have any effect if Kerberos is disabled, so it's ultimately cont Sure, but the question is whether it's better to provide a way to set custom base for the principal instead of the hard-coded "oryx"? Also, do we still want to have coverage for default principal 'kudu' when running kerberized MasterHmsTest? -- To view, visit http://gerrit.cloudera.org:8080/17350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8d9e208da1d767bb24470ab031a5266461d070b Gerrit-Change-Number: 17350 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 27 Apr 2021 20:47:31 +0000 Gerrit-HasComments: Yes
