Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17350 )
Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17350/1/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/17350/1/src/kudu/integration-tests/master_hms-itest.cc@78 PS1, Line 78: opts.principal = Princip > I adjusted it so that it works like EnableKerberos(). I don't think we need Thank you for addressing this. OK, if it's just a matter of plumbing and we are comfortable to switching MasterHmsKerberizedTest to always using custom principal, I guess it's fine. I just wanted to pointed that with current patch the case of non-set/empty KUDU_SASL_PROTOCOL_NAME isn't exercised, IIUC. -- To view, visit http://gerrit.cloudera.org:8080/17350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8d9e208da1d767bb24470ab031a5266461d070b Gerrit-Change-Number: 17350 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 28 Apr 2021 02:06:40 +0000 Gerrit-HasComments: Yes
