Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17350 )
Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17350/1/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/17350/1/src/kudu/integration-tests/master_hms-itest.cc@78 PS1, Line 78: opts.principal = "oryx"; > Sure, but the question is whether it's better to provide a way to set custo I adjusted it so that it works like EnableKerberos(). I don't think we need to run it with/without the default given both are effectively just a set string on the client and the in depth testing of the client connectivity was done during the addition of the principal API. This is just pluming it to the HMS client and validating the plumbing. -- To view, visit http://gerrit.cloudera.org:8080/17350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8d9e208da1d767bb24470ab031a5266461d070b Gerrit-Change-Number: 17350 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 28 Apr 2021 01:37:22 +0000 Gerrit-HasComments: Yes
