Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 )
Change subject: KUDU-3223: Management of per-table level limit ...................................................................... Patch Set 35: (2 comments) http://gerrit.cloudera.org:8080/#/c/17273/35/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17273/35/src/kudu/master/catalog_manager.cc@344 PS35, Line 344: std::numeric_limits<int64_t>::max(), Ah I missed this in my last round of reviews. Rather than setting this to an explicit value, can we go back to using -1 as a default, and making sure that the SysTablesEntryPB doesn't set these fields if specified as -1? http://gerrit.cloudera.org:8080/#/c/17273/35/src/kudu/master/catalog_manager.cc@3446 PS35, Line 3446: TableMetadataLock table_lock(table.get(), LockMode::READ); Seems like when this is called, we have already locked the table for reads. In that case, would it make sense to just pass the l.data().pb as a const ref argument to this function instead of the TableInfo? -- To view, visit http://gerrit.cloudera.org:8080/17273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dbf365ad59f17c0a4e2e7ea6a5afaa7680724b0 Gerrit-Change-Number: 17273 Gerrit-PatchSet: 35 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 03 May 2021 19:41:08 +0000 Gerrit-HasComments: Yes
