Hongjiang Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 )
Change subject: KUDU-3223: Management of per-table level limit ...................................................................... Patch Set 36: (2 comments) http://gerrit.cloudera.org:8080/#/c/17273/35/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17273/35/src/kudu/master/catalog_manager.cc@344 PS35, Line 344: "This is a system wide configuration > Ah I missed this in my last round of reviews. Rather than setting this to a Ack http://gerrit.cloudera.org:8080/#/c/17273/35/src/kudu/master/catalog_manager.cc@3446 PS35, Line 3446: } > Seems like when this is called, we have already locked the table for reads. But I also need table->GetMetrics()->on_disk_size, then I have to pass several arguments. -- To view, visit http://gerrit.cloudera.org:8080/17273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dbf365ad59f17c0a4e2e7ea6a5afaa7680724b0 Gerrit-Change-Number: 17273 Gerrit-PatchSet: 36 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 04 May 2021 05:06:45 +0000 Gerrit-HasComments: Yes
