Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17273 )
Change subject: KUDU-3223: Management of per-table level limit ...................................................................... Patch Set 39: Verified+1 Code-Review+1 (1 comment) One more comment, otherwise this LGTM! The test failure were unrelated. http://gerrit.cloudera.org:8080/#/c/17273/39/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17273/39/src/kudu/master/catalog_manager.cc@3454 PS39, Line 3454: table_disk_size_limit = pb.table_disk_size_limit(); : table_rows_limit = pb.table_row_count_limit(); We don't need these now that we're setting them below, right? -- To view, visit http://gerrit.cloudera.org:8080/17273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dbf365ad59f17c0a4e2e7ea6a5afaa7680724b0 Gerrit-Change-Number: 17273 Gerrit-PatchSet: 39 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 05 May 2021 07:28:56 +0000 Gerrit-HasComments: Yes
