Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17376 )
Change subject: [util] Add special handling for empty strings in FastHash ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/17376/5/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/17376/5/src/kudu/tserver/tablet_service.cc@1371 PS5, Line 1371: case TabletServerFeatures::BLOOM_FILTER_PREDICATE_V2: Do you know what happens now if a BLOOM_FILTER_PREDICATE (V1) request is made? Does it fail? I suppose that is okay because we need the fix and we only expect Impala to use this feature currently, but we should remember to document that the client must be >= this version to use bloomfilters on upgrade. -- To view, visit http://gerrit.cloudera.org:8080/17376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb2d401ab692decd5bc03b48a96d710546c0039e Gerrit-Change-Number: 17376 Gerrit-PatchSet: 5 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Sun, 16 May 2021 02:46:42 +0000 Gerrit-HasComments: Yes
