Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17376 )
Change subject: [util] Add special handling for empty strings in FastHash ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/17376/5/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/17376/5/src/kudu/tserver/tablet_service.cc@1371 PS5, Line 1371: case TabletServerFeatures::BLOOM_FILTER_PREDICATE_V2: If the client supplies BLOOM_FILTER_PREDICATE and the server with this change only supports BLOOM_FILTER_PREDICATE_V2 then the request will fail with missing feature. > I suppose that is okay because we need the fix and we only expect Impala to > use this feature currently, > but we should remember to document that the client must be >= this version to > use bloomfilters on upgrade. Ack. -- To view, visit http://gerrit.cloudera.org:8080/17376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb2d401ab692decd5bc03b48a96d710546c0039e Gerrit-Change-Number: 17376 Gerrit-PatchSet: 5 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 17 May 2021 14:23:02 +0000 Gerrit-HasComments: Yes
