Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17376 )
Change subject: [util] Add special handling for empty strings in FastHash ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/17376/5/src/kudu/client/predicate-test.cc File src/kudu/client/predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/17376/5/src/kudu/client/predicate-test.cc@1551 PS5, Line 1551: int i = 0; : int last_flush = i; : while (i < kNumRows) { : for (int j = 0; j < values.size() && i < kNumRows; j++, i++) { : const string &value = values[j]; : unique_ptr<KuduUpsert> upsert(table->NewUpsert()); : ASSERT_OK(upsert->mutable_row()->SetInt64("key", i)); : ASSERT_OK(upsert->mutable_row()->SetStringNoCopy("value", value)); : ASSERT_OK(session->Apply(upsert.release())); : } : // TSAN builds timeout and fail on flushing with large number of rows. : if (i - last_flush >= 1000) { : ASSERT_OK(session->Flush()); : last_flush = i; : } : } : ASSERT_OK(session->Flush()); > I'm a bit confused about this change -- in the commit message you mention w Earlier the number of "values" was 8 and 8 is a divisor of 1000 (kNumRows/ 10). Once "values" is raised to 9, 9 is not a divisor of 1000 so the condition on L1561 never evaluated to true. This resulted in missed flushes which resulted in failures on TSAN build. -- To view, visit http://gerrit.cloudera.org:8080/17376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb2d401ab692decd5bc03b48a96d710546c0039e Gerrit-Change-Number: 17376 Gerrit-PatchSet: 5 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 17 May 2021 22:09:27 +0000 Gerrit-HasComments: Yes
