Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17486 )
Change subject: KUDU-3277 fix concurrent session flush issue in Java client ...................................................................... Patch Set 2: > I am not sure I like the idea of skipping tests under certain test > run types. Can we reduce the work the test is doing and still > reliably reproduce so that the test doesn't timeout in tsan? > Reducing numSessions and numRowsPerSession will likely help. I didn't see firm reproduction of the issue if drastically reducing the number of sessions and rows written, and the scenario under TSAN is still flaky even if reducing the load to barely have the issue reproducing itself: http://dist-test.cloudera.org//job?job_id=aserbin.1621804245.42503# What aspect you don't like particularly in skipping tests for ASAN/TSAN binaries? We have multiple tests like that for the backend, where the whole test scenario is skipped: * TestCFileBothCacheMemoryTypes.TestReadWriteLargeStrings (skipped) * ThreadPoolTest.TestDeadlocks (skipped) * DebugUtilTest.TestUnwindWhileUnsafe (skipped) * TsRecoveryITestDeathTest.TestRecoverFromOpIdOverflow (skipped) Also, about hundred of test scenarios has special settings for ASAN/TSAN builds. In this context we are not testing the back-end as is, so what's wrong with skipping the test if running against binaries built with ASAN/TSAN? -- To view, visit http://gerrit.cloudera.org:8080/17486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6aaccc06abf1a2673620ab7c649f51f91999ad9 Gerrit-Change-Number: 17486 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 23 May 2021 21:39:42 +0000 Gerrit-HasComments: No
