Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17486 )
Change subject: KUDU-3277 fix concurrent session flush issue in Java client ...................................................................... Patch Set 2: I can be convinced otherwise. My gut is that unless there is something that makes running under TSAN impossible/untenable, we should try to run the tests across all of the build types. Looking at the 4 examples you mention, that is why they 3/4 are disabled. TestReadWriteLargeStrings is the only one disabled due to running slowly in TSAN. I am okay with this approach if making the test run well under TSAN isn't feasible. -- To view, visit http://gerrit.cloudera.org:8080/17486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6aaccc06abf1a2673620ab7c649f51f91999ad9 Gerrit-Change-Number: 17486 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 23 May 2021 22:03:05 +0000 Gerrit-HasComments: No