Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17486 )
Change subject: KUDU-3277 fix concurrent session flush issue in Java client ...................................................................... Patch Set 2: > I can be convinced otherwise. My gut is that unless there is > something that makes running under TSAN impossible/untenable, we > should try to run the tests across all of the build types. Looking > at the 4 examples you mention, that is why they 3/4 are disabled. > TestReadWriteLargeStrings is the only one disabled due to running > slowly in TSAN. I am okay with this approach if making the test run > well under TSAN isn't feasible. I tried to make it work under TSAN: 32 sessions, 5000 rows per session (vs original 50 and 10000 rows). Unfortunately, in that case the issue isn't reliably reproducible under any build type, but for TSAN it's still 15% flaky :( I'm striving to have reproduction rate close to 100% here. I'd be happy to have a way to resolve this without introducing TSAN-specific nonsense, but unfortunately I didn't find a way to do so, at least this time. I guess we could remove that newly introduced TSAN-related nonsense one day once we have a firm repro. Maybe, that means we need to tweak the RPC timeout and make it longer? We will see. Thank you very much for the review! -- To view, visit http://gerrit.cloudera.org:8080/17486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6aaccc06abf1a2673620ab7c649f51f91999ad9 Gerrit-Change-Number: 17486 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 23 May 2021 22:20:06 +0000 Gerrit-HasComments: No
