Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17607 )
Change subject: [metrics] KUDU-3269: Add UUID and hostname of the server into the metrics output ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17607/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17607/2//COMMIT_MSG@16 PS2, Line 16: "hostname": "MacBook-Pro.local", > Had a chat with Alexey on the IP address adding part. I think hostname and I filed KUDU-3269 with the rationale to add identification for collected tablet server metrics, so it's possible to tell which server the metrics were collected from given just the output from the `/metrics` endpoint. UUID and name of the node is enough in that scope. As for the IP addresses, there are too many options, actually: * RPC server bound IP address(es) * Web server bound IP address(es) * advertised IP address(es) If adding those IP addresses, I'd vote to do so in a separate patch. -- To view, visit http://gerrit.cloudera.org:8080/17607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d6d1e96f8067a7b1593da4f9d0e1931d3001016 Gerrit-Change-Number: 17607 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 23 Jun 2021 20:53:05 +0000 Gerrit-HasComments: Yes
