Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17607 )
Change subject: [metrics] KUDU-3269: Add UUID and hostname of the server into the metrics output ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/17607/3/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17607/3/src/kudu/server/server_base.cc@855 PS3, Line 855: GetFQDN Is it possible to reuse the result of the prior call to GetFQDN() instead of calling it here once more? What about falling back to GetHostname() if GetFQDN() didn't succeed? If it's not worth making a call to GetHostName() when GetFQDN() failed, maybe add a small in-line comment for the reasoning behind always sticking to FQDN()? http://gerrit.cloudera.org:8080/#/c/17607/3/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/17607/3/src/kudu/tserver/tablet_server-test.cc@3824 PS3, Line 3824: nit: this indent seems a bit off http://gerrit.cloudera.org:8080/#/c/17607/3/src/kudu/tserver/tablet_server-test.cc@3828 PS3, Line 3828: GetHostname Is this still working as expected once switched to FQDN? -- To view, visit http://gerrit.cloudera.org:8080/17607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d6d1e96f8067a7b1593da4f9d0e1931d3001016 Gerrit-Change-Number: 17607 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 23 Jun 2021 20:59:20 +0000 Gerrit-HasComments: Yes
