Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17607 )
Change subject: [metrics] KUDU-3269: Add UUID and hostname of the server into the metrics output ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17607/3/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17607/3/src/kudu/server/server_base.cc@855 PS3, Line 855: > The implementation of GetFQDN() involves calling GetHostname() to update th Ah, that makes sense. For some reason, I thought we need to tell between failures of GetHostname() and GetAddrInfo() in the implementation of GetFQDN(). It seems in this case supplying either an empty string or the result of GetHostname() is OK, and the same warning would be generated in both cases. Which is not perfect, but it's OK in this context. Overall, looks acceptable. Thank you for adding the comment. -- To view, visit http://gerrit.cloudera.org:8080/17607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d6d1e96f8067a7b1593da4f9d0e1931d3001016 Gerrit-Change-Number: 17607 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 24 Jun 2021 06:31:25 +0000 Gerrit-HasComments: Yes
