Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17528 )
Change subject: [master] AddMaster and copy sys catalog automatically ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17528/4/src/kudu/master/master_runner.cc File src/kudu/master/master_runner.cc: http://gerrit.cloudera.org:8080/#/c/17528/4/src/kudu/master/master_runner.cc@218 PS4, Line 218: if (cstate.has_pending_config()) { : LOG(INFO) << Substitute("Existing masters have pending config: $0", : SecureShortDebugString(cstate.pending_config())); : *needs_retry = true; : return Status::OK(); Probably thought of already, but does it make sense to verify the raft configuration index too? I see we are ensuring if the latest raft config is committed in each master and verifying the election term too -- To view, visit http://gerrit.cloudera.org:8080/17528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7635723f30317a45799ad7b9c9b725eafbd735b Gerrit-Change-Number: 17528 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 07 Jul 2021 14:58:17 +0000 Gerrit-HasComments: Yes
