Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17528 )
Change subject: [master] AddMaster and copy sys catalog automatically ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/17528/4/src/kudu/master/master_runner.cc File src/kudu/master/master_runner.cc: http://gerrit.cloudera.org:8080/#/c/17528/4/src/kudu/master/master_runner.cc@367 PS4, Line 367: RETURN_NOT_OK(ValidateHiveMetastoreSaslEnabled()); : : MasterOptions opts; : unique_ptr<Master> server(new Master(opts)); > Thanks for adding that new test. Ah, that's a good point. E.g. if one of the masters goes off the grid somehow and is totally unreachable by DNS resolution, it's worth considering that as a bad master rather than a failure to start. I'll follow-up in a separate patch, rather than ballooning this one further. -- To view, visit http://gerrit.cloudera.org:8080/17528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7635723f30317a45799ad7b9c9b725eafbd735b Gerrit-Change-Number: 17528 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 13 Jul 2021 22:16:11 +0000 Gerrit-HasComments: Yes
