Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17528 )
Change subject: [master] AddMaster and copy sys catalog automatically ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17528/4/src/kudu/master/master_runner.cc File src/kudu/master/master_runner.cc: http://gerrit.cloudera.org:8080/#/c/17528/4/src/kudu/master/master_runner.cc@367 PS4, Line 367: RETURN_NOT_OK(VerifyMastersGetHostPorts(opts.master_addresses(), : local_uuid, server->messenger(), : &leader_hp, &local_hp, : &try_again, &needs_add)); > Added. Keep in mind that the masters are still up, per L352. These addition Thanks for adding that new test. Yeah, I understand the master is already started. My point was to make sure VerifyMastersGetHostPorts() isn't about to bail with non-OK status in some edge cases when not all masters are up and running in short interval. BTW, what happens at line 160 if one of the masters' addresses isn't resolvable? E.g., imagine one of the master nodes is down and its address is not temporarily not resolvable because they are going through some procedure to replace a master. Would it be possible to start other two masters and have a working cluster in such a situation? -- To view, visit http://gerrit.cloudera.org:8080/17528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7635723f30317a45799ad7b9c9b725eafbd735b Gerrit-Change-Number: 17528 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 13 Jul 2021 05:34:10 +0000 Gerrit-HasComments: Yes
