Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17674 )
Change subject: KUDU-3304: [Alter] Support to alter table's replication factor ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/17674/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17674/1/src/kudu/client/client.h@1724 PS1, Line 1724: FLAGS_max_num_replicas nit: public-facing API docs should refer to this as --max_num_replicas. http://gerrit.cloudera.org:8080/#/c/17674/1/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/17674/1/src/kudu/master/master.proto@736 PS1, Line 736: uint32 nit: typically we avoid unsigned integer types. See https://google.github.io/styleguide/cppguide.html#Integer_Types Especially given 'num_replicas' is an int32 type. http://gerrit.cloudera.org:8080/#/c/17674/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: PS1: It'd be great to also add an end-to-end test ensuring that Kudu correctly does the right thing and adds new replicas. And removes replicas when lowering the replication factor. integration-tests/tablet_replacement-itest.cc or integration-tests/alter_table-test.cc seem like good candidates. -- To view, visit http://gerrit.cloudera.org:8080/17674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aa2d5b12c508ba761fa9410ad1a465cf31fb7d7 Gerrit-Change-Number: 17674 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 13 Jul 2021 02:26:22 +0000 Gerrit-HasComments: Yes
