Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17674 )
Change subject: KUDU-3304: [Alter] Support to alter table's replication factor ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/integration-tests/alter_table-test.cc@2242 PS4, Line 2242: 0 nit: -1 http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/integration-tests/alter_table-test.cc@2267 PS4, Line 2267: } Do you mind adding a test scenario to verify the case when trying to set replication factor to 5 while there are just 4 tablet servers in the cluster? http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/master/catalog_manager.cc@3062 PS4, Line 3062: has_metadata_changes_for_existing_tablets Should this be also be set to true if table's replication factor is being updated? http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/tools/kudu-tool-test.cc@4482 PS4, Line 4482: const string& kTableName nit: could could be a constexrp: constexpr const char* const kTableName = ...; http://gerrit.cloudera.org:8080/#/c/17674/4/src/kudu/tools/kudu-tool-test.cc@4546 PS4, Line 4546: } Does it make sense to add a scenario to check setting replication factor to 5 when there are just 4 tablet servers? -- To view, visit http://gerrit.cloudera.org:8080/17674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aa2d5b12c508ba761fa9410ad1a465cf31fb7d7 Gerrit-Change-Number: 17674 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 14 Jul 2021 03:18:51 +0000 Gerrit-HasComments: Yes
