Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17674 )
Change subject: KUDU-3304: [Alter] Support to alter table's replication factor ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17674/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17674/4//COMMIT_MSG@14 PS4, Line 14: unit tests It would be great to add a test for the meta-cache in the KuduClient, and also making sure AlterTable() awaits for the operation to complete (i.e. the request number of replicas are up and running once AlterTable() returns when changing the replication factor). A good place for such test scenarios is client-test.cc -- there are somewhat similar scenarios in there. -- To view, visit http://gerrit.cloudera.org:8080/17674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aa2d5b12c508ba761fa9410ad1a465cf31fb7d7 Gerrit-Change-Number: 17674 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 14 Jul 2021 03:30:56 +0000 Gerrit-HasComments: Yes
