Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17684 )
Change subject: [catalog_manager] introduce --min_num_replicas flag ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/client/client-test.cc@5356 PS3, Line 5356: const vector<pair<int, string>> cases = { > can't this be expanded with the new test cases instead of creating separate Not quite cleanly: it's necessary to have more tablet servers than 1 to properly test min_num_replicas, so it would require resetting the 'cluster_' created by ClientTest::SetUp() But I guess it's better to do the opposite: move these scenario over into the new test. I'll do so. http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/client/client-test.cc@5359 PS3, Line 5359: {2, "illegal replication factor 2: replication factor must be odd"}, > is there any reason for changing parentheses for colons? A few reasons: (1) it's less symbols with a semicolon (2) it's inline with the majority of error messages elsewhere (3) it's quite uncommon to put essential information in parenthesis http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/master/catalog_manager.cc@487 PS3, Line 487: if (FLAGS_max_num_replicas % 2 == 0 && > is this check duplicated? I don't see a duplicate: at line 479 the check is against FLAGS_min_num_replicas http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/master/catalog_manager.cc@497 PS3, Line 497: should > nit: here and below, "should" should be replaced with "must" The following approach is used here: "must" is when it have to be so unless kudu-master won't start because the settings are inconsistent so a new table could not be created. Using "should" here means "it's not what expected, but kudu-master starts anyway with a warning" -- it's still possible to create a table if overriding the default replication factor explicitly in client API. Do you rather think the discrepancy between --default_num_replicas and --min_num_replicas should also be a reason to not starting a kudu-master process? -- To view, visit http://gerrit.cloudera.org:8080/17684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86191fcdc1b4ed6670f33ba7176d28dbd1df541f Gerrit-Change-Number: 17684 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 15 Jul 2021 14:35:28 +0000 Gerrit-HasComments: Yes
