Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17684 )
Change subject: [catalog_manager] introduce --min_num_replicas flag ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/client/client-test.cc@5359 PS3, Line 5359: {2, "illegal replication factor 2: replication factor must be odd"}, > A few reasons: (1) it's less symbols with a semicolon (2) it's inline with Done http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/master/catalog_manager.cc@487 PS3, Line 487: if (FLAGS_max_num_replicas % 2 == 0 && > I don't see a duplicate: at line 479 the check is against FLAGS_min_num_rep I don't know how I didn't see that, sorry... http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/master/catalog_manager.cc@497 PS3, Line 497: should > The following approach is used here: "must" is when it have to be so unless I believe it would lead to a better user experience, yes. -- To view, visit http://gerrit.cloudera.org:8080/17684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86191fcdc1b4ed6670f33ba7176d28dbd1df541f Gerrit-Change-Number: 17684 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 15 Jul 2021 14:46:43 +0000 Gerrit-HasComments: Yes
