Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17684 )
Change subject: [catalog_manager] introduce --min_num_replicas flag ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/client/client-test.cc@5372 PS3, Line 5372: ); nit: maybe print the error, now that we're not going to see it with the ASSERT_STR_CONTAINS() http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/master/catalog_manager.cc@479 PS3, Line 479: if (FLAGS_min_num_replicas % 2 == 0 && : !FLAGS_allow_unsafe_replication_factor) { : LOG(ERROR) << Substitute( : "--min_num_replicas ($0) must not be an even number since " : "--allow_unsafe_replication_factor is not set", : FLAGS_min_num_replicas); : return false; : } : if (FLAGS_max_num_replicas % 2 == 0 && : !FLAGS_allow_unsafe_replication_factor) { : LOG(ERROR) << Substitute( : "--max_num_replicas ($0) must not be an even number since " : "--allow_unsafe_replication_factor is not set", : FLAGS_max_num_replicas); : return false; : } It seems more natural to check that --default_num_replicas for evenness, rather than the min/max values. I.e. it seems acceptable for the min/max to be non-valid RFs but at the very least the default RF should be valid. http://gerrit.cloudera.org:8080/#/c/17684/3/src/kudu/master/catalog_manager.cc@497 PS3, Line 497: should > I believe it would lead to a better user experience, yes. +1 -- To view, visit http://gerrit.cloudera.org:8080/17684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86191fcdc1b4ed6670f33ba7176d28dbd1df541f Gerrit-Change-Number: 17684 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 15 Jul 2021 17:33:38 +0000 Gerrit-HasComments: Yes
