Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17692 )
Change subject: [test] deflake dynamic_multi_master-test ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/17692/2/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/17692/2/src/kudu/integration-tests/master_hms-itest.cc@749 PS2, Line 749: ASSERT_TRUE(s.IsTimedOut()) << s.ToString(); > This looks like an unrelated change. It's actually relevant. Added a comment to WaitForTabletServerCount(). http://gerrit.cloudera.org:8080/#/c/17692/2/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/17692/2/src/kudu/master/dynamic_multi_master-test.cc@223 PS2, Line 223: master.registration().rpc_addresses_size() != 1 > Why is having multiple master registration addresses a problem? I don't think it's a problem per se, but it's not something we expect. In any case, I just copied the condition from VerifyVoterMastersForCluster(). If you feel strongly about this, I can change both. http://gerrit.cloudera.org:8080/#/c/17692/2/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/17692/2/src/kudu/mini-cluster/external_mini_cluster.cc@734 PS2, Line 734: for (const auto& iter : masters_to_search) { > for-range loop would work fine for this case. Done -- To view, visit http://gerrit.cloudera.org:8080/17692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67c5ac38701c4283611dc95e17f9f054c90aba99 Gerrit-Change-Number: 17692 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 26 Jul 2021 22:01:36 +0000 Gerrit-HasComments: Yes
