Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17692 )
Change subject: [test] deflake dynamic_multi_master-test ...................................................................... [test] deflake dynamic_multi_master-test The test was flaky for a few reasons: - retries to create a table could end up with the table already created, and an AlreadyPresent error was not being caught. This patch treats such errors as benign. - ExternalMiniCluster::WaitForTabletServerCount() could previously fail if the RPCs sent therein failed because the master wasn't yet ready to serve RPCs. This patch first pings the masters, retrying until all masters can be pinged, indicating the health of their RPC layers. - VerifyVoterMastersForCluster() would previously only verify the voters according to the leader master. This wouldn't fly upon restarting the cluster, since lagging masters could fail to start up with a mismatched on-disk Raft config. Without this patch, the test would fail ~1% of the time in debug mode with --stress_cpu_threads=3. With this patch, it passed 1000/1000 times. Change-Id: I67c5ac38701c4283611dc95e17f9f054c90aba99 Reviewed-on: http://gerrit.cloudera.org:8080/17692 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/integration-tests/master_hms-itest.cc M src/kudu/master/dynamic_multi_master-test.cc M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/mini-cluster/external_mini_cluster.h 4 files changed, 58 insertions(+), 7 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/17692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I67c5ac38701c4283611dc95e17f9f054c90aba99 Gerrit-Change-Number: 17692 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
