Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17692 )
Change subject: [test] deflake dynamic_multi_master-test ...................................................................... Patch Set 4: Code-Review+2 (4 comments) Thank you for fixing this flake! http://gerrit.cloudera.org:8080/#/c/17692/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17692/4//COMMIT_MSG@23 PS4, Line 23: WIth nit: with http://gerrit.cloudera.org:8080/#/c/17692/4/src/kudu/mini-cluster/external_mini_cluster.h File src/kudu/mini-cluster/external_mini_cluster.h: http://gerrit.cloudera.org:8080/#/c/17692/4/src/kudu/mini-cluster/external_mini_cluster.h@418 PS4, Line 418: within nit: drop 'within'? http://gerrit.cloudera.org:8080/#/c/17692/4/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/17692/4/src/kudu/mini-cluster/external_mini_cluster.cc@734 PS4, Line 734: iter nit: while 'iter' is a good generic name for an iterator, maybe replace this with 'master' or alike in this context? http://gerrit.cloudera.org:8080/#/c/17692/4/src/kudu/mini-cluster/external_mini_cluster.cc@746 PS4, Line 746: 1 nit while you are at it: 1 millisecond for polling for a process's start-up looks too often -- does it make sense to change this and another pause at line 783 to be 10 milliseconds? -- To view, visit http://gerrit.cloudera.org:8080/17692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67c5ac38701c4283611dc95e17f9f054c90aba99 Gerrit-Change-Number: 17692 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 27 Jul 2021 00:30:06 +0000 Gerrit-HasComments: Yes
