Hello Mahesh Reddy, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17694
to look at the new patch set (#3).
Change subject: KUDU-2671 remove semantically duplicate range_hash_schemas
......................................................................
KUDU-2671 remove semantically duplicate range_hash_schemas
This patch removes the 'range_hash_schemas' field from
CreateTableRequestPB because the field was semantically duplicating the
'range_hash_schemas' sub-field of the already existing
'partition_schema' field. This change doesn't break any compatibility
because the corresponding client side which uses the removed field
hasn't yet been released.
In addition, this patch fixes invalid memory access condition (SIGSEGV)
in PartitionSchema::EncodeRangeBounds() in case if
the number of per range hash schemas and range bounds "
+ "must have the same size
With the removal of the semantically duplicate field, the check for
the validity of per-range hash bucket ranges is restored. This patch
adds a new test scenario to verify that the validation is now in place
and to catch regressions in the future.
I also updated the corresponding code in the C++ client and tests.
This is a follow-up to 23ab89db1 and 586b79132.
Change-Id: Icde3d0b0870fd3a3941fcc91602993ae7ad46266
---
M src/kudu/client/client.cc
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
M src/kudu/integration-tests/table_locations-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master.proto
9 files changed, 256 insertions(+), 165 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/17694/3
--
To view, visit http://gerrit.cloudera.org:8080/17694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icde3d0b0870fd3a3941fcc91602993ae7ad46266
Gerrit-Change-Number: 17694
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
