Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17694 )
Change subject: KUDU-2671 remove semantically duplicate range_hash_schemas ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17694/4/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17694/4/src/kudu/common/partition.cc@426 PS4, Line 426: if (bounds_with_hash_schemas->empty()) { : return Status::OK(); : } > As for the statement that the code below is skipped anyways, I'd suggest pa ah good catch, I'll be sure to look out for underflow cases like this in the future and pay more attention to any implicit conversion between different signed types. -- To view, visit http://gerrit.cloudera.org:8080/17694 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icde3d0b0870fd3a3941fcc91602993ae7ad46266 Gerrit-Change-Number: 17694 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 27 Jul 2021 19:14:20 +0000 Gerrit-HasComments: Yes
