Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17694 )
Change subject: KUDU-2671 remove semantically duplicate range_hash_schemas ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17694/4/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17694/4/src/kudu/common/partition.cc@426 PS4, Line 426: if (bounds_with_hash_schemas->empty()) { : return Status::OK(); : } > nit: Is this just for readability purposes to make this code more explicit? As for the statement that the code below is skipped anyways, I'd suggest paying some attention to signed/unsigned implicit conversions. In other words, try the code below: #include <vector> #include <iostream> using namespace std; int main() { vector<int> m; for (int i = 0; i < m.size() - 1; i++) { cout << "have fun" << endl; } return 0; } -- To view, visit http://gerrit.cloudera.org:8080/17694 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icde3d0b0870fd3a3941fcc91602993ae7ad46266 Gerrit-Change-Number: 17694 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 27 Jul 2021 18:41:12 +0000 Gerrit-HasComments: Yes
