Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17694 )
Change subject: KUDU-2671 remove semantically duplicate range_hash_schemas ...................................................................... KUDU-2671 remove semantically duplicate range_hash_schemas This patch removes the 'range_hash_schemas' field from CreateTableRequestPB because the field was semantically duplicating the 'range_hash_schemas' sub-field of the already existing 'partition_schema' field. This change doesn't break any compatibility because the corresponding client side which uses the removed field hasn't yet been released. In addition, this patch fixes an invalid memory access condition (sometimes leading to SIGSEGV) in PartitionSchema::EncodeRangeBounds() if the number of per range hash schemas is less than the number of range bounds. With the removal of the semantically duplicate field, the check for the validity of per-range hash bucket ranges is now effective. This patch adds a new test scenario to verify that the validation is now in place and to catch regressions in the future. I also updated the corresponding code in the C++ client and tests. This is a follow-up to 23ab89db1 and 586b79132. Change-Id: Icde3d0b0870fd3a3941fcc91602993ae7ad46266 Reviewed-on: http://gerrit.cloudera.org:8080/17694 Reviewed-by: Andrew Wong <[email protected]> Tested-by: Kudu Jenkins Reviewed-by: Mahesh Reddy <[email protected]> --- M src/kudu/client/client.cc M src/kudu/client/flex_partitioning_client-test.cc M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master-test.cc M src/kudu/master/master.proto 9 files changed, 260 insertions(+), 168 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified Mahesh Reddy: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/17694 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icde3d0b0870fd3a3941fcc91602993ae7ad46266 Gerrit-Change-Number: 17694 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]>
