Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/9490 )
Change subject: [tools] Add a tool to recover master data from tablet servers ...................................................................... Patch Set 6: Code-Review+1 (5 comments) LGTM. Minor comments. http://gerrit.cloudera.org:8080/#/c/9490/5/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/9490/5/src/kudu/tools/kudu-admin-test.cc@3001 PS5, Line 3001: NO_FATALS(ClusterVerifier(cluster_.get()).CheckCluster()); Can we also run the cluster verifier before deleting the recreated table? http://gerrit.cloudera.org:8080/#/c/9490/6/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/9490/6/src/kudu/tools/master_rebuilder.cc@115 PS6, Line 115: ProcessReplica Nit: It'd be good to give a name that describes the action like CreateOrCheckTablet() http://gerrit.cloudera.org:8080/#/c/9490/6/src/kudu/tools/master_rebuilder.cc@209 PS6, Line 209: .Equals Nit:Not this change but this looks like Java instead of using operator overloading with == in C++. http://gerrit.cloudera.org:8080/#/c/9490/6/src/kudu/tools/master_rebuilder.cc@302 PS6, Line 302: master.Shutdown(); Should we also try to clean up the created tables in case of any errors while writing to sys catalog? http://gerrit.cloudera.org:8080/#/c/9490/5/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/9490/5/src/kudu/tools/tool_action_master.cc@931 PS5, Line 931: "possibility of recovering the original masters, and you know what you\n" I know we have a way to enforce permissions in the RPC layer. Could we restrict this CLI to admin users, if possible? -- To view, visit http://gerrit.cloudera.org:8080/9490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If29e421d466a531ebad72e281ae27e74e458f8c6 Gerrit-Change-Number: 9490 Gerrit-PatchSet: 6 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 02 Aug 2021 23:17:12 +0000 Gerrit-HasComments: Yes
