Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9490 )
Change subject: [tools] Add a tool to recover master data from tablet servers ...................................................................... Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/9490/9/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/9490/9/src/kudu/tools/kudu-admin-test.cc@3133 PS9, Line 3133: we c > nit: drop Done http://gerrit.cloudera.org:8080/#/c/9490/9/src/kudu/tools/master_rebuilder.h File src/kudu/tools/master_rebuilder.h: http://gerrit.cloudera.org:8080/#/c/9490/9/src/kudu/tools/master_rebuilder.h@35 PS9, Line 35: Object for a > nit: this is not a POD type since its non-static members are not PODs. If Indeed. Thanks for the pointer! http://gerrit.cloudera.org:8080/#/c/9490/9/src/kudu/tools/master_rebuilder.h@81 PS9, Line 81: const RebuildReport& GetRebuildReport() const; > nit: make this method 'const'? Done http://gerrit.cloudera.org:8080/#/c/9490/9/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/9490/9/src/kudu/tools/master_rebuilder.cc@63 PS9, Line 63: using kudu::master::SysCatalogTable; : using kudu::master::SysTablesEntryPB; : using kudu::master::SysTabletsEntryPB; : using kudu::master::TableInfo; : using kudu::master::TableMetadataLock; : using kudu::master::TabletInfo; : using kudu::master::TabletMetadataGroupLock; : using kudu::master::TabletMetadataLock; : using kudu::tserver::ListTabletsResponsePB; : using std::string; : using std::vector; : using strings::Substitute; : : namespace kudu { > nit: move these using declarations out from the kudu namespace Done http://gerrit.cloudera.org:8080/#/c/9490/9/src/kudu/tools/master_rebuilder.cc@155 PS9, Line 155: assembled all > Would IllegalState/Incomplete/ServiceUnavailable be better choices here? Done http://gerrit.cloudera.org:8080/#/c/9490/9/src/kudu/tools/master_rebuilder.cc@321 PS9, Line 321: Status s = sys_catalog.CreateNew(master.fs_manager()); > As an option, would it be a safer approach to create the whole master's fil It's a good point, similar to Bankim's mention of cleaning up files. I'll leave a TODO here. I don't expect failures to run the tool to show up too frequently, so I'd opt to defer that until we see it being an issue. I can address it in a follow up if you feel strongly about it. -- To view, visit http://gerrit.cloudera.org:8080/9490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If29e421d466a531ebad72e281ae27e74e458f8c6 Gerrit-Change-Number: 9490 Gerrit-PatchSet: 10 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 11 Aug 2021 06:50:37 +0000 Gerrit-HasComments: Yes
