Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9490 )
Change subject: [tools] Add a tool to recover master data from tablet servers ...................................................................... Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/9490/5/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/9490/5/src/kudu/tools/kudu-admin-test.cc@3001 PS5, Line 3001: NO_FATALS(MakeTestTable(kTable, /*num_rows*/10, /*num_repl > Can we also run the cluster verifier before deleting the recreated table? Done http://gerrit.cloudera.org:8080/#/c/9490/6/src/kudu/tools/master_rebuilder.cc File src/kudu/tools/master_rebuilder.cc: http://gerrit.cloudera.org:8080/#/c/9490/6/src/kudu/tools/master_rebuilder.cc@115 PS6, Line 115: state_pb = ta > Nit: It'd be good to give a name that describes the action like CreateOrChe Done http://gerrit.cloudera.org:8080/#/c/9490/6/src/kudu/tools/master_rebuilder.cc@209 PS6, Line 209: > Nit:Not this change but this looks like Java instead of using operator over Done http://gerrit.cloudera.org:8080/#/c/9490/6/src/kudu/tools/master_rebuilder.cc@302 PS6, Line 302: return Status::Corruption("inconsistent replica: partition mismatch"); > Should we also try to clean up the created tables in case of any errors whi Missed this. I'll update the patch with this. http://gerrit.cloudera.org:8080/#/c/9490/5/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/9490/5/src/kudu/tools/tool_action_master.cc@927 PS5, Line 927: " table to --default_num_replicas instead.\n" > I'd add a note about missing cryptographic keys stored in the catalog table Done http://gerrit.cloudera.org:8080/#/c/9490/5/src/kudu/tools/tool_action_master.cc@931 PS5, Line 931: " - Table metadata like comments, owners, and configurations are not stored on\n" > I know we have a way to enforce permissions in the RPC layer. Could we rest If fine-grained authorization is enforced, only the admin can run this, since it relies on ListTablets. AuthorizeListTablets() only permits super-users. -- To view, visit http://gerrit.cloudera.org:8080/9490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If29e421d466a531ebad72e281ae27e74e458f8c6 Gerrit-Change-Number: 9490 Gerrit-PatchSet: 7 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 09 Aug 2021 18:55:41 +0000 Gerrit-HasComments: Yes
