Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17725 )
Change subject: KUDU-3204: Add a metric for amount of available space ...................................................................... Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/17725/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17725/7//COMMIT_MSG@26 PS7, Line 26: the > nit: remove Done http://gerrit.cloudera.org:8080/#/c/17725/7//COMMIT_MSG@27 PS7, Line 27: fs_data_dirs_available_space_cache_seconds > nit: add -- Done http://gerrit.cloudera.org:8080/#/c/17725/7/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/17725/7/src/kudu/fs/data_dirs.cc@85 PS7, Line 85: . " > nit: there's an extra space here too Done http://gerrit.cloudera.org:8080/#/c/17725/7/src/kudu/fs/data_dirs.cc@85 PS7, Line 85: > nit: in the Done http://gerrit.cloudera.org:8080/#/c/17725/7/src/kudu/integration-tests/disk_failure-itest.cc File src/kudu/integration-tests/disk_failure-itest.cc: http://gerrit.cloudera.org:8080/#/c/17725/7/src/kudu/integration-tests/disk_failure-itest.cc@357 PS7, Line 357: > nit: extra space Done http://gerrit.cloudera.org:8080/#/c/17725/7/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17725/7/src/kudu/server/server_base.cc@269 PS7, Line 269: l" > nit: fails Done http://gerrit.cloudera.org:8080/#/c/17725/7/src/kudu/util/env.h File src/kudu/util/env.h: http://gerrit.cloudera.org:8080/#/c/17725/7/src/kudu/util/env.h@49 PS7, Line 49: > nit: remove the extra newline Done -- To view, visit http://gerrit.cloudera.org:8080/17725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58a7419847d080498aaf431d1dab098e1af71ad0 Gerrit-Change-Number: 17725 Gerrit-PatchSet: 7 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 17 Aug 2021 21:57:15 +0000 Gerrit-HasComments: Yes
