Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17725 )
Change subject: KUDU-3204: Add a metric for amount of available space ...................................................................... Patch Set 10: Verified+1 Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/17725/10/src/kudu/integration-tests/disk_failure-itest.cc File src/kudu/integration-tests/disk_failure-itest.cc: http://gerrit.cloudera.org:8080/#/c/17725/10/src/kudu/integration-tests/disk_failure-itest.cc@352 PS10, Line 352: E nit: got a couple extra spaces here http://gerrit.cloudera.org:8080/#/c/17725/10/src/kudu/integration-tests/disk_failure-itest.cc@364 PS10, Line 364: ASSERT_OK(itest::GetInt64Metric(cluster_->tablet_server(0)->bound_http_hostport(), : &METRIC_ENTITY_server, nullptr, &METRIC_wal_dir_space_available_bytes, "value", : &wal_dir_space)); : ASSERT_OK(itest::GetInt64Metric(cluster_->tablet_server(0)->bound_http_hostport(), : &METRIC_ENTITY_server, nullptr, &METRIC_data_dirs_space_available_bytes, "value", : &data_dir_space)); : ASSERT_NE(wal_dir_space, -1); nit: we can use get_metrics() here too, right? -- To view, visit http://gerrit.cloudera.org:8080/17725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58a7419847d080498aaf431d1dab098e1af71ad0 Gerrit-Change-Number: 17725 Gerrit-PatchSet: 10 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 20 Aug 2021 00:47:23 +0000 Gerrit-HasComments: Yes
