Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17725 )
Change subject: KUDU-3204: Add a metric for amount of available space ...................................................................... Patch Set 4: (2 comments) Will address the rest of the pointed out issues in the next patch http://gerrit.cloudera.org:8080/#/c/17725/4/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/17725/4/src/kudu/server/server_base.cc@437 PS4, Line 437: FLAGS_fs_data_dirs_available_space_cache_seconds > Not sure if we want to use a separate flag for wal dir caching? As discussed with Andrew offline will add a new flag. http://gerrit.cloudera.org:8080/#/c/17725/4/src/kudu/server/server_base.cc@443 PS4, Line 443: wal_dir_available_space = -1; : return wal_dir_available_space; > As a user, I'm curious if it would make sense to leave the value as is on f Yes, that makes sense. Will try to ensure: 1. For WAL dir failure initialize it to -1 and return the last known value in case of disk failure after the TS started 2. For data dir initialize it to -1 and skip the calculation of disk space whose statvfs fails. So in case of complete initial failure of wal or all data disks, -1 will be returned -- To view, visit http://gerrit.cloudera.org:8080/17725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58a7419847d080498aaf431d1dab098e1af71ad0 Gerrit-Change-Number: 17725 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 03 Aug 2021 02:30:00 +0000 Gerrit-HasComments: Yes
