Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17852 )
Change subject: [ntp] fix two arithmetic operator ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17852/1/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/17852/1/src/kudu/clock/hybrid_clock.cc@587 PS1, Line 587: poll_backoff_ms << 1 I'm not sure this brings any optimization: I guess the compiler is smart enough to do its on its own, at least if compiling in release mode. Did you see any change in the generated assembly after this update? -- To view, visit http://gerrit.cloudera.org:8080/17852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5775d9206e82dfd1febd98219dbde1bb69a44240 Gerrit-Change-Number: 17852 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 17 Sep 2021 04:56:18 +0000 Gerrit-HasComments: Yes
